This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
Added 1984 ISA 1976 Standard atmosphere with tests. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These version of ISA is designed to be called with only one value of altitude instead of an array. Performance improvements can be done with numba.
| for ii, h_ in enumerate(h): | ||
| T, p, rho = atm(h_) | ||
| assert_almost_equal(T, expected_T[ii], decimal=3) | ||
| assert_almost_equal(rho, expected_rho[ii], decimal=4) |
|
He añadido un par de comentarios estilísticos de poca importancia pero el fondo está perfecto 👍 |
…es section and the available altitude range in the function.
|
He hecho unos cambios en esa rama. Supongo que se actualiza automáticamente y no tengo que hacer otro pull request, no? |
|
@AlexS12 Efectivamente, la rama queda asociada al pull request 😁 |
|
Si no hay más propuestas de cambios se puede hacer el merge |
|
|
astrojuanlu
added a commit
that referenced
this pull request
Jan 4, 2016
Add 1984 ISA 1976 Standard atmosphere with tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These version of ISA is designed to be called with only one value of altitude instead of an array. Performance improvements can be done with numba.
He tomado como base la rama de la ISA que hizo Juanlu con ligeras modificaciones:
Este Pull Request cerrará #9